-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update abseil to a release tag and register neural_speed #19255
Conversation
Where is neural speed used? Can you write it in the PR desc? |
It's a dependency added by this PR: The library is used in the x64 MatMulNBits implementation. |
Neural speed is an open source library that was introduced in PR #19016 . The PR was made by Intel, and there was some left job for compliance stuffs. I told them they can merged the PR first and I would take care of the remaining compliance things. That's what this PR is doing. |
Later on I will also create a PR to update https://github.com/microsoft/onnxruntime/blob/main/ThirdPartyNotices.txt . |
Any reason we need a separate PR for ThirdPartyNotices? It'll be nice to have a single PR that shows all the files that need to be updated to incorporate a new 3P dep. This way it can be used as a reference PR to add new deps. |
The procedure is: first we should register any new dependency to CG. Then CG will use the information to go through some internal review. During the process I will also need to provide some additional information. Then after the review is done, we update the ThirdPartyNotices.txt. You may think the internal process is to ensure the text that is adding to ThirdPartyNotices.txt is accurate. |
### Description Update abseil to a release tag and register neural_speed to CG. ### Motivation and Context Now we are using a non-relesed version of abseil. Using a tag is better.
Description
Update abseil to a release tag and register neural_speed to CG.
Motivation and Context
Now we are using a non-relesed version of abseil. Using a tag is better.